Changeset 1fa4120a0445d0692f6e35fbc512ed95c16d9080

Timestamp:

12/16/08 11:32:57 (3 years ago)

Author:

Lincoln de Sousa <lincoln@…>

Children:

dc6d6ff67aa9be656398ff38c2dc74af60162cc2

Parents:

f900ed0e2fd323b79bc64e5297248bcbeb80480d

git-committer:

Lincoln de Sousa <lincoln@…> (12/16/08 11:32:57)

Message:

Making the popup notification be shown in the end of
the Guake class constructor, it was done to make sure
that guake really started before showing this notification.

This patch is a contribution made by Pierre-Yves aka pingou =)

Files:

• src/guake.py (modified) (3 diffs)

src/guake.py

@@ -104 +104 @@
         label = gtk.accelerator_get_label(keyval, mask)
 
-        filename = pixmapfile('guake-notification.png')
-        if not globalhotkeys.bind(key, self.show_hide):
-            n = pynotify.Notification(_('Guake!'),
-                _('A problem happened when binding <b>%s</b> key.\n'
-                  'Please use guake properties form to choose another '
-                  'key') % label, filename)
-        else:
-            n = pynotify.Notification(_('Guake!'),
-                _('Guake is already running,\n'
-                  'press <b>%s</b> to use it.') % label, filename)
-        n.show()
-
         # trayicon!
         tray_icon = GuakeStatusIcon()
@@ -165 +153 @@
         self.window.set_geometry_hints(min_width=1, min_height=1)
         self.window.connect('focus-out-event', self.on_window_lostfocus)
+        self.get_widget('context-menu').set_accel_group(self.accel_group)
 
         # resizer stuff
         self.resizer.connect('motion-notify-event', self.on_resizer_drag)
-            
-        self.get_widget('context-menu').set_accel_group(self.accel_group)
 
         self.load_accel_map()
@@ -177 +164 @@
         self.add_tab()
         self.toggle_ontop()
+
+        # Pop-up that shows that guake is working properly (if not
+        # unset in the preferences windows)
+        filename = pixmapfile('guake-notification.png')
+        if not globalhotkeys.bind(key, self.show_hide):
+            n = pynotify.Notification(_('Guake!'),
+                _('A problem happened when binding <b>%s</b> key.\n'
+                  'Please use guake properties form to choose another '
+                  'key') % label, filename)
+        else:
+            n = pynotify.Notification(_('Guake!'),
+                _('Guake is already running,\n'
+                  'press <b>%s</b> to use it.') % label, filename)
+        n.show()
 
     def on_resizer_drag(self, widget, event):