Changeset 4c3249ae933490bae2947df246d18404dcec59d6

Timestamp:

02/24/09 17:02:24 (3 years ago)

Author:

Lincoln de Sousa <lincoln@…>

Children:

6e7a465a714dfa3038e4278695b5ac2b7c8748a1

Parents:

b79b94619f249cd3e89db6e5f93747e4dd1cf5ba

git-author:

Aleksandar Krsteski <alekrsteski@…> (02/19/09 00:16:34)

git-committer:

Lincoln de Sousa <lincoln@…> (02/24/09 17:02:24)

Message:

Fixing a bug when zsh is used as default shell.

Zsh exited immediately when empty list was passed as argv argument. This
occurred when using zsh without enabled login_shell option, causing an
infinite loop with tab creation and destroying. To fix this default the
argv to None.

Signed-off-by: Aleksandar Krsteski <alekrsteski@…>

Files:

• src/guake.py (modified) (1 diff)

src/guake.py

@@ -870 +870 @@
         method of a vte terminal.
         """
-        argv = []
+        argv = None
         shell = self.client.get_string(KEY('/general/default_shell')) or 'sh'
         login_shell = self.client.get_bool(KEY('/general/use_login_shell'))
         if login_shell:
-            argv.append('-')
+            argv = ['-']
 
         directory = self.get_current_dir()
-        return shell, argv, None, directory, login_shell, None, None
+        return shell, argv, None, directory, login_shell, False, False
 
     def add_tab(self, *args):