specify size

[Brinbois]

the horizontal size is always 100% but if you are a double-scree, the terminal is on the both. Why not in parameters demand the width and heigth ??

sorry for my language, i'am french

[steved]

i am looking into this now. there is another similar ticket logged regarding specifying the width of Guake, so I will try to incorporate both requirements in the patch.

[lincoln]

Hmm, I saw the other bug about main window width, but I'm not sure if these two bugs talks about the same thing.

And about this bug... I never used guake with a dualhead, so I'll install another monitor in my pc to think how guake should handle this kind of environment =)

[myElrond]

It would be a nice feature to be able to limit guake terminal to one screen and/or to a specific horizontal resolution. Even on a single screen with a higher resolution (e.g. 1900x1200) it would be useful to be able to limit the size of the window.

I suggest some preference items like

Size of guake window: (Whole horizontal desktop size/Specific Screen only/Specific resolution only)

Horizontal Position: (centered/left/right)

Vertical Position: (Scroll down from top/Scroll up from bottom)

[nao]

It would be nice to align Guake to the bottom, not only to the top of screen.

[13k]

I'm submitting a patch (yes, it's git-format-patch'ed) that adds horizontal size and alignment options to preferences.

I think this fixes #91 too (since it's basically the same fix which the user in that bug used to quickly-n-dirty fix it).

update: I WAS sending the patch. TRAC blocked me, with a permission denied.

I am pasting the patch as a gist in Github instead, here's the link:  http://gist.github.com/60696

PS: Dá um jeito nisso ae! =)

[13k]

I forgot to mention that I did not added support to localization in anything of my changes/additions. The truth is that I don't know how to do it and was lazy enough to not spend a time reading the code to find out how to do it. It's everything in english, at least.

[lincoln]

Replying to 13k:

I'm submitting a patch (yes, it's git-format-patch'ed) that adds horizontal size and alignment options to preferences. I think this fixes #91 too (since it's basically the same fix which the user in that bug used to quickly-n-dirty fix it).

Very nice =)

update: I WAS sending the patch. TRAC blocked me, with a permission denied.

Humm, sorry about that, I'll look at this problem right now.

I am pasting the patch as a gist in Github instead, here's the link:  http://gist.github.com/60696

Nature finds a way! (ps.: use gitorious insted of github, it is free =)

I'll find some time to look at your patch, review it and try to apply asap!

PS: Dá um jeito nisso ae! =)

Hahaha, xá cumigo malandro!

Thank you amigão!

[lincoln]

Hmm, after looking at bug #102 I think we should think more about what to do in this case. Maybe we should be a bit more flexible and not only make it possible to define horizontal configuration.

I'll think more, please post your opinions.

[pingou]

oups I haven't seen lincoln's latest comment

[13k]

Replying to lincoln:

Hmm, after looking at bug #102 I think we should think more about what to do in this case. Maybe we should be a bit more flexible and not only make it possible to define horizontal configuration. I'll think more, please post your opinions.

Why do not apply this patch now and make incremental changes after that? I've seen however you changed the concept of window size to window rect. I can adapt the patch to accomodate this change.

Inclusion of options that are not related to this (sliding from sides) in this same bug seems to be making a clump of non-overlapping subjects.

[OolongBrothers]

Hi, I agree that the basic horizontal-size thing should be just incorporated for now. It can help a lot in working around different multi-monitor issues. E.g. I'm using the nvidia driver's twin view for multi-monitor. Guake is shown perfectly fitting on the left monitor when I invoke the hotkey when my cursor is on that left monitor. When my cursor is on the right monitor, guake gets invoked on the left monitor too (which is totally fine I find) only that the width is taken from the right monitor's resolution. My right monitor has a lower resolution than my left one, so guake is just horizontally somewhat short. It is still aligned to the left desktop edge. If there was a fixed width option, one could work around many quirks of all the different multi-monitor technologies without having to test everything with all of those.

Or what do you think, would you rather want to fix the nvidia-specific stuff? I could also file an individual bug for that.

I'm using the getdeb-build of guake 0.4.

Regards and thanks for this great software, Alex

[svtdragon]

A friend and I running a homegrown mod that allows one to adjust horizontal position and horizontal size with sliders in the prefs menu. Position goes from left to right as a percentage, and the precise position depends on the size: if the slider is all the way to the left, the left side of the terminal will be against the left side of the screen, and if it's all the way to the right, the right side of the terminal will be against the right side of the screen. If you adjust the size slider, it grows and moves accordingly. If it's centered on the screen (or otherwise not on the edge), it grows from both sides.

There are some quirks if it grows until it collides with the edge of the screen (then the position bar doesn't readjust itself automatically) but given the fact that Guake is hidden when one enters the preferences menu, I don't think it's a terribly big deal since the slider will reset itself to its actual value (where it actually appears on the screen) if you open/close preferences. On the whole, though, it gives you the ability to have it anywhere, any size, on any of multiple screens.

On another note, the very first time a fresh install is run with our modifications, we get a 1px by 1px terminal in the top left corner. As soon as we right click that pixel though, and enter the menu and adjust the sliders, it works fine from then on out. Any insight as to why this is?

Let me know if you're interested in the source for this (I'm not familiar with git).

[astratto]

A patch to rename window_size to window_width

[astratto]

A patch to allow width resizing

[astratto]

A patch to specify the alignment

[astratto]

I was working on this before reading this ticket... :D Now I've merged my work with the patch posted by 13k.

I've splitted (and attached) everything in 3 patches: 1. a simple patch to rename window_size to window_height 2. a patch to allow width resizing 3. a patch to specify the alignment

Maybe now working on these patches can be easier. Currently I'm adding some hotkeys to allow both vertical and horizontal resizing, should I create another ticket for this?

[13k]

Good to know, I'm really looking forward to see this option making into Guake settings.

Are you a core developer? Anyone from core can give any feedback on this?

[pingou]

Lincoln is quite busy at the moment but I will try to have him have a look at these patches :-)

Thanks a lot for contributing to guake :-)

[astratto]

13k: no, I'm not a core dev.

pingou: thank you. I'd like to be able to set these options using shortcuts as well. It would be great if lincoln could review these patches. (As I said, I'm working on shortcuts for this but I've got some issues I hope to solve in the next days.)

[lincoln]

Hello there, as our friend pingou said, I'm quite busy these days, I've reviewed and pushed a simple patch right now, but this is a bigger one, so I'll need more time to review it. But I'll try to do it at this night, ok?

Thank you very much for your job!

[lincoln]

So, well done, your patches are really nice. I've just applied them against my priv tree. I have just only one tip:

We'll have to provide a way for choosing heads (mointors), see #124 and #91, so, maybe we should create another tab, called Presentation, Position, Display or something like that and put these options in that new tab.

What do you think about it?

ps.: I'll push your patches once we define this.

Thanks!

[13k]

Yes, there are too many new settings related to positioning that a new tab will be necessary ("window size" itself is already alone in the last possible position in the bottom of the first tab).

Future or probable new settings like "where the window slides from" would fit this new tab too.

[lincoln]

Replying to 13k:

Yes, there are too many new settings related to positioning that a new tab will be necessary ("window size" itself is already alone in the last possible position in the bottom of the first tab). Future or probable new settings like "where the window slides from" would fit this new tab too.

Yes, maybe we should look at all configurations available (and being proposed) and try to make them as simpler as possible and merge everything we can to save some screenspace and to keep our loved guake like other gnome apps, simple and clear. =P

[lincoln]

Another thing I'm thinking is about generalize the 'horizontal alignment' option. Maybe we should give the option to choose the gravity of the window. I'll upload a screenshot and an svg file. Maybe it will make more users happy =P

Another point of this change is the bug #102. That some people would like to see the terminal sliding in sideways, with the window gravity approach we can reach this feature easily.

So, just another idea and no patches being pushed, humm, I'm a bad guy =(

[lincoln]

preferences with window gravity

[pingou]

This sounds to me like a new page on the wiki :)

Cool that was one needed page !

I also join you guys on the need to clearly separate the configuration and create a new tab for those :)

[lincoln]

svg image with the gravity stuff

[pingou]

This design is not complete. Using it there are some cases we cannot distinguish How distinguish:

• Window sliding from the top and being of the left side of the screen (so horizontal window)

from

• Window sliding from the side and being at the top part of the screen (so vertical window here)

To correct that I think a simple radio button vertical/horizontal button should do the trick because then: - vertical window -> always slide from the side whatever gravity is selected (except the middle ones) - horizontal window -> always slide from the top or the bottom whatever gravity is selected

The user can then play with height and width to give to his window the shape he wants.

The only points are the middle (sides or top/bottom) should be disable according to the type of window asked (horizontal/vertical)

[lincoln]

Replying to pingou:

This sounds to me like a new page on the wiki :)

Indeed! I think we'll need to think more about it and centralizing our ideas in a wiki page is really necessary!

Cool that was one needed page ! I also join you guys on the need to clearly separate the configuration and create a new tab for those :)

Yup, I've started the mockup contest, but we still need to include stuff from #102 and #124 and I think it should be placed in the same tab...

[svtdragon]

Thanks everyone for making this project. I easily use it every day. This will be a huge addition to the functionality of Guake. :)

Let me know if there's anything you can use from my ideas or coding ability.

To sum up and clarify for me, there's going to be a new tab that allows users to select screen gravity as either from the sides or top/bottom? I can see how being able to choose from any of the four sides would be useful, especially if one's using it at 100% width.

There will be display selection (are we aiming for compatibility with xinerama, twinview...? I run a machine with dual GPUs and aim to be getting more than just the two monitors I have now. Will this be affected by whether someone's using ATI or nVidia? I know multiple monitors have traditionally been configured in slightly different ways on each vendor. )

And there will be fully-adjustable height, width, and position? For example, right now, with my modifications, since by default Guake would span my two monitors, I have it set at something like 25% horizontal width and 25% horizontal position to put it at half the size of the monitor, and in the middle of my left monitor, and I've got it at about 33% vertical size. Is it going to be fully-customizable, in the sense that one can put it anywhere on the screen at any size?

[pingou]

Fully customizable is the general idea.

You will be able to chose whether you want the window to be on the right, left, top or bottom part of you screen, choice the gravity (left, middle, right) and play with height and width for the rest :)

That's actually covers pretty much all the cases I can think of :)

And yes, this should work in all screen and all graphic cards :-D (else feel free to bug us here ;-))

[astratto]

Replying to lincoln:

So, well done, your patches are really nice. I've just applied them against my priv tree. I have just only one tip: We'll have to provide a way for choosing heads (mointors), see #124 and #91, so, maybe we should create another tab, called Presentation, Position, Display or something like that and put these options in that new tab. What do you think about it?

Sorry I was on holiday. However, I second the 13k's suggestion of working incrementally especially to avoid overengineering. Closing 3 bugs would be great, but maybe we should focus on closing this for now?

About the preferences, I've just seen your mockup, in my opinion it's a good idea to separate these settings.