Can't effectively switch between tabs after Terminal 1 closed

[viniosity]

If you're working with multiple tabs and you close Terminal 1, switching between tabs no longer works. To reproduce

1. Launch Guake 2. Create a new tab (Terminal 2) 3. Perform some action on Terminal 2 (ssh, etc) 4. Switch to Terminal 1 and type exit 5. Create a new tab (Terminal 3) 6. Switching back to Terminal 2 shows same output as on Terminal 3

System: Linux AMD 64, Debian Sid

[keksinat0r]

Same here

Linux x86_64, Debian Lenny/Sid? Linux x86_64, Debian Etch

[SAWADA Takeo]

I think this patch will fix this problem

---
 src/guake.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/guake.py b/src/guake.py
index 5afcb5e..abc8a33 100644
--- a/src/guake.py
+++ b/src/guake.py
@@ -903,7 +903,7 @@ class Guake(SimpleGladeApp):
         bnt.set_property('draw-indicator', False)
         bnt.connect('button-press-event', self.show_tab_menu)
         bnt.connect('clicked', lambda *x:
-                        self.notebook.set_current_page(last_added))
+                        self.notebook.set_current_page(self.notebook.page_num(box)))
         bnt.show()
 
         self.tabs.pack_start(bnt, expand=False, padding=1)
-- 
1.5.6.5

[lincoln]

Hurry to apply this patch =)

Thank you!!

[lincoln]

Just testing upload stuff, it was broken sometime ago.

[lincoln]

Than you for your patch SAWADA Takeo, I've already commited and pushed to the server.

I have a little tip for you, use git-format-patch when sending me a patch, by this way your name will be present in commiter message.

Thank you again =)