Ticket #115 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Shortcut in context menu

Reported by: pingou Owned by: somebody
Priority: critical Milestone: 0.4.0
Component: guake Version:
Keywords: Cc:

Description

In the latest git:

  • right click on guake
  • look at the shortcut for copy and paste

They show ctrl+c/ctrl+v which is not really what they are :-D

I tried a patch here but it seems that my glade rewrote the whole file, I still attached it here in case... :-)

Attachments

guake.glade.patch Download (22.4 KB) - added by pingou 4 years ago.
Patch for contextual menu
0001-patch-context-menu.patch Download (22.8 KB) - added by pingou 4 years ago.
context menu patch
0001-Fix-invalid-keyboard-shortcuts-in-context-menu.patch Download (11.3 KB) - added by SnapShot 4 years ago.

Change History

Changed 4 years ago by pingou

Patch for contextual menu

Changed 4 years ago by pingou

I attached a still durty patch but at least this one works :)

Changed 4 years ago by pingou

context menu patch

Changed 4 years ago by SnapShot

I have also tried to modify the context menu but it seems like my Glade version is also not compatible. It doesn't change the whole file like pingou's Glade but it doesn't work properly.

I wonder what version was used for creating the glade files of guake.

Changed 4 years ago by lincoln

I've used glade-3.5.2 but as you said glade is screwing up all the file when saving a simple change... The last changes I'm doing in Guake are being maid in Emacs.

I'll try to make the changes in glade file without changing other parts of file, maybe try to use gazpacho or burn all glade/libglade stuff and rebuild ui using gtkbuilder (if we find a editor).

Changed 4 years ago by SnapShot

I am using glade 3.5.4 and it is not working corectly with the glade files. I have also thought suggesting to move from libglade to GtkBuilder? if it imrpoves things. Glade 3.5.4 is supporting GtkBuilder? files but I am not sure how it works with them.

Changed 4 years ago by SnapShot

Another try to get a clean modification of the glade. This is the cleanest patch that we could get IMHO. It works fine on my system.

Changed 4 years ago by SnapShot

Try again... I hope this is final :D

Changed 4 years ago by SnapShot

Again... :D

Changed 4 years ago by SnapShot

Changed 4 years ago by lincoln

  • status changed from new to closed
  • resolution set to fixed

Thanks to Pingou and SnapShot? for your great work, we have another bug killed =)

Note: See TracTickets for help on using tickets.