Ticket #122 (closed defect: fixed)
|Reported by:||SnapShot||Owned by:||somebody|
I think this is not related to the other dual monitor problem that is targeted for 0.5.0.
This patch fixes the problem that apears when default monitor is not left monitor. Guake always uses the left monitor (position 0,0) but gets the width of the default monitor which can be on right. More details in commit message ;)
I have reworked the get_final_window_size function but there is one part of the code commented like "avoiding X Window system error" that I am not sure what's the purpose. It looks ilogical to me, it get's the height of the screen in pixels and then compares it to the height configured by the user which is in percents.
I don't think it makes sense to compare percents with pixels, something like if 60 > 1050. And even if we can compare them I can't see what we would achive with that. Let's say screen size is 50px what will we get is that 60% is bigger than 50px and then we will make the height equal to screen height so height will be 50%.
I think this part of the code is remaining from some older version where guake kept the height preference in pixels, and then it made sense to compare if the height specified by the user is bigger then monitor height.