Add monitor selection to guake

[regit]

The following patches add monitor selection to guake. It adds the capability to choose on which monitor guake will appear.

[regit]

I've rebased my work on the current git tree and I've also cleaned up the UI patch:

• 0001-Add-monitor-choice-to-UI.patch
• 0002-Add-capability-to-set-up-monitor-in-multiple-monitor.patch
• 0003-Limit-range-of-monitor-to-avoid-crash.patch

[SnapShot]

Thanks regit for your patches. This was one of the planned features for 0.5.0.

Your patch adds new page in the preferences dialog, just as we planned to implement it (we additionally need to move other display options to the new tab page).

Two issues that I see with the patches are:

• your second patch adds back the code commented with "# avoiding X Window system error" which was intentionally removed in one of our latest commits.
• IMHO it is better to use ComboBox? instead of SpinButton? for monitor choice.

Our intention was to initially do some other base changes to the guake in 0.5.0 development, like moving to GtkBuilder? and UIManager, and possibly some build system changes, before adding new features, so your patches may need to wait a little until we start working on 0.5.0 (which is very soon).

[pyriku]

Hi

I created a new patch based on the posted by regit, but working on the development version.

It also improves some things:

• It's a ComboBox?, that fills with the number of screens given by  http://www.pygtk.org/docs/pygtk/class-gdkscreen.html#method-gdkscreen--get-n-monitors
• It's not a new tab on the preferences dialog, it's just a new option on the main tab.

[mahmoudimus]

Thanks for the patch pyriku! I tried it and it works beautifully :) Thank you very much for this.

[Trisfall]

Just want to say thanks - this worked for me too.

Although it would be helpful if somewhere in the FAQ or something it told you how to install a patch, because I spent over 3 hours just trying to figure that out (I'm also completely new to Linux so, yeah).

[amog2011]

Your patch adds new page in the preferences dialog, just as we planned to implement it (we additionally need to move other display options to the new tab page).

air jordan