Request Guake Confirm Quit

[phip]

I just pressed Ctrl-Shift-Q when I meant to press Ctrl-Shift-W, and Guake quit without any warning. I request a preference to confirm before quitting or confirm before closing tabs with non-shell processes active, like many terminals have.

[lincoln]

nice suggestion!

[makism]

i`m sure if this is needed...

[makism]

the actual prompt dialog

[makism]

I thought it would be a great feature so i`ve made a simple patch which works well. The code for tracking how many processes are running is taken from the gnome-terminal.

The number of patches is big because the "prompt dialog" is a glade file. I could just use the gtk.Dialog class etc but i thought that i should follow the coding style and inherit from simplegladeapp. It also adds an option to the settings.

I think that maybe there is something wrong with the prefs.glade and my glade-3 binary, because after i edited it changed some things that i did not touch. But still it works fine.

I`ll be happy if i can be any of more help :-)

[makism]

updated patch. 1) hides the main window when prompting and 2) showing again on cancel. finally, 3) raises the prompt dialog on top of everything (at least in theory)

[lincoln]

Hello there!

I'm reviewing your changes. I just loved your ideas, mainly the process count stuff.

ps.: It would be very easier to review things if you use git format-patch utility. Downloading and applying multiple patch files is not the best way =P

[lincoln]

Hello again!

I've just reviewed, fixed some things and pushed your patches. Thanks a lot for your help dude! To fit some of our standards I had to change some things in them. Here is a list of things I changed:

• Coding standard fixes: removing unecessary white spaces, lower case some variable names.
• Implemented the PromptOnQuit? class without the glade file (will help us migrate to gtk builder)
• Removed all unrelated changes from the prefs.glade file

Thanks again, very nice job!