[regresion] rename tabs not working

[mainiak]

hi,

after update to 4.1-1 (archlinux) stopped for me renaming of tabs at all

after I do keypress for renaming and hit enter with new name, it collaps to tab with NOTHING in it - and worse of it is, it can't be easily selected :-/

but nice job otherwise

p.s.: I do renaming for _1-, _2-, _3 to get ALT+NUM selecting of tabs!

[Acegi]

Hi I'm using guake on Arch Linux too same version 0.4.1 and I am having the same problems. When I click on rename the tab loses it's name, shrinks and it becomes harder to click. Please fix this soon.

I also agree that it would be good if you could select the tabs by using Alt+Number. Tab 1 = Alt+1, Tab 2 = Alt+2 ... etc but this should probably be in a different ticket.

[kipelovets]

hi. i have the same problem on ubuntu 9.10: after upgrading to 4.1 renaming stopped working. when i try to rename a tab it loses it's name

[kipelovets]

i'd become tired of this tabs issue, so i've tried to fix it myself, although i'm not a python programmer.

i've found out that moving the dialog destruction code (guake.py line 983) down after the code that sets the tab label (line 986) actually solves the problem. so the the code that works for me look like this:

        response = dialog.run()
        # dialog.destroy() 

        if response == gtk.RESPONSE_ACCEPT:
            self.selected_tab.set_label(entry.get_text())

        dialog.destroy()

maybe there is some problem with gtk and dialogs, but i haven't found any code changes connected with gtk in the version 0.4.1 diff.

also, before making any changes i've tried to rename current tab from command line with option '--rename-tab' and it worked.

i hope this helps

[lincoln]

Hello there, sorry for delaying, having a hard time on my job =/

About this issue... As you see, we're calling the destroy method of the dialog widget before calling entry.get_text(). It is not wise, since the dialog.destroy() will call all its children's destroy method too.

Your suggestion is not exactly perfect too, since you don't destroy the widget after using it. But it was very useful to help me just look at the problem and realize what was happening.

Thank you very much, I've just pushed the correction to our master branch.

[lincoln]

Hehe, I forgot to close the ticket... sorry!