Ticket #3 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

error on close tab

Reported by: warwolf Owned by: GabrielFalcao
Priority: major Milestone:
Component: component1 Version:
Keywords: Cc:

Description

When you close ANY tab, ALLWAYS the program closes the LAST tab.

[Tested in Ubuntu 8.04 adn Ubuntu 7.10]

Change History

Changed 5 years ago by steved

Problem here is that the on_close_button_close_clicked function sends the delete_tab function the name of the terminal object, not the name of its parent.

This function just needs this line...

        self.delete_tab(self.notebook.page_num(self.term_list[index]))

...change to this...

        self.delete_tab(self.notebook.page_num(self.term_list[index].get_parent()))

Changed 5 years ago by steveD

I was a bit optimistic earlier - this requires further changes.

I have also noticed that the terminal process (Bash in my case) is not being killed, resulting in ever increasing memory usage (can anyone else confirm they also have this??). I will need to check this, but may require another ticket logging. :(

Changed 5 years ago by steveD

I have now submitted a patch that should resolve both these issues.

Changed 5 years ago by GabrielFalcao

  • owner changed from somebody to GabrielFalcao

Changed 5 years ago by lincoln

  • status changed from new to closed
  • resolution set to fixed

SteveD's patch commited.

Changed 5 years ago by warwolf

  • status changed from closed to reopened
  • resolution fixed deleted

After de the patch, now I can't close the last tab

Changed 5 years ago by lincoln

  • status changed from reopened to closed
  • resolution set to fixed

These issues were already fixed in git master branch.

Thanks for contributing.

Note: See TracTickets for help on using tickets.