Tray icon optional

[pingou]

Hi,

I have submitted some patches (about the version 2.0) not long ago (before discovering this wiki) to make the trail icon optional.

If my patches are not used, could that still be done ?

I also report that the n.show() statement that show the pop up windows at the start of guake should be put at the end of the if, else if something breaks between the n.show() and the end of the if, you have the pop up window but not guake...

I still have the patched I have made if that can help just ask me please :)

[lincoln]

Hi,

Sorry for delay to answer. I saw your patch when you sent it by mail and I like your idea. But I think your patch does not apply in the current master branch. Can you help us to make it apply again?

About the bug reported, I can't reproduce that, if it doesn't work for you, please open a new ticket describing the problem.

Thank you very much =)

[pingou]

hm, is there a problem with the Git repo ?
I can not access to it
 http://repos.guake-terminal.org/guake/ returns a 404
and git clone  git://repos.guake-terminal.org/guake[[BR]] returns
Initialized empty Git repository in /home/pierrey/Desktop/guake/.git/
repos.guake-terminal.org[0: 72.249.191.46]: errno=Connection refused
fatal: unable to connect a socket (Connection refused)
fetch-pack from ' git://repos.guake-terminal.org/guake' failed.

Regards

[lincoln]

hi!

Maybe you got our downtime when setting guake repo in a new server.

try again with

{{ $ git clone  git://repos.guake-terminal.org/guake }}

ps.: our http server is no longer maintained.

[pingou]

ok there are the new patches.

I have not tested them with the latest version of guake since I can not build from the git right now (it is missing the configure file).
Basically I used the previous patch and just adapt them to the new files.

Let me know what you think of it.

For the n.show() it is not a real bug, but while playing around with guake I broke it a couple of time and observed that the pop up was present but guake not.
I think it is also a matter of doing since in the right order, starting every thing and showing the pop up after, but in fact it probably does not matter as long as the user does not break guake ;-)

Thanks,

pierre

[lincoln]

Replying to pingou:

ok there are the new patches. I have not tested them with the latest version of guake since I can not build from the git right now (it is missing the configure file).

Actually we don't maintain the configure file in repos, it's generated just after running autogen.sh script.

Basically I used the previous patch and just adapt them to the new files.

I think we'll have no problems to merge that into the updated source, you changed specific places that doesn't bother the rest of the code (nice job =).

Let me know what you think of it.

I found some issues in guake.py.patch (Guake.toggle_tray):

• you're mixing tabs with spaces
• comparing a boolean with False (it needn't to be so explicit =)
• the tray icon shouldn't be destroyed in every toggle, it should be only hidden/shown.
• And that try/except is not necessary.

but I'm going to fix that before merging with the new code.

The rest of the patch looks nice!

For the n.show() it is not a real bug, but while playing around with guake I broke it a couple of time and observed that the pop up was present but guake not.
I think it is also a matter of doing since in the right order, starting every thing and showing the pop up after, but in fact it probably does not matter as long as the user does not break guake ;-)

Hehe, let's test it more, maybe we can improve this part too =)

ps.: We're starting to freeze the code to release the 0.3 version, and adding a new feature can make the code more unstable, so I think the best idea is target this ticket to the 0.4 version.

Thanks, pierre

Thank you too =)

[pingou]

I found some issues in guake.py.patch (Guake.toggle_tray): * you're mixing tabs with spaces

oups sorry about that

* comparing a boolean with False (it needn't to be so explicit =) * the tray icon shouldn't be destroyed in every toggle, it should be only hidden/shown.

Did not try this as you have seen :)

* And that try/except is not necessary.

Well it was necessary since the method I used did not work... but once the method is properly set I guess would not be needed any more.

Could you show me the change you finally make ? I am curious :) (To be honest this is almost the first patch I send back that add a new feature)

ps.: We're starting to freeze the code to release the 0.3 version, and adding a new feature can make the code more unstable, so I think the best idea is target this ticket to the 0.4 version.

I have no problem with that, but then I will be looking forward for the release 0.4 :)

Thanks, Pierre

[pingou]

New patches made for the last version from git sent to the developers

[pingou]

From the recent change only the patch for guake.py has to be changed with the new one for prefs.py

[pingou]

New patches for guake.py and prefs.py sent

[lincoln]

After so many time I'm glad to finally close this bug as fixed.

Thank you very much Pingou, for your patches, your help in all the process and for your patience =)