Ticket #51 (closed enhancement: fixed)

Opened 5 years ago

Last modified 12 months ago

Tango palette color theme by default

Reported by: n3rd3x Owned by: n3rd3x
Priority: minor Milestone:
Component: guake Version: 0.3.1
Keywords: Cc: czert, kristjan.eerik.kaseniit+guake@…

Description

the theme tango is much more beautiful and usable standard that the issue of vte!

Attachments

palettes.patch Download (57.4 KB) - added by tatofoo 3 years ago.
Let you choose a color palette in the preferences dialog
0001-Updated-the-preferences-dialog.patch Download (51.2 KB) - added by tatofoo 3 years ago.
These patches were made with git format-patch
0002-Updated-the-gconf-schema.patch Download (1.3 KB) - added by tatofoo 3 years ago.
These patches were made with git format-patch
0003-Now-it-shows-the-color-scheme-set-in-gconf.patch Download (2.4 KB) - added by tatofoo 3 years ago.
These patches were made with git format-patch
0004-Updated-the-corresponding-code-of-the-preferences-wi.patch Download (3.9 KB) - added by tatofoo 3 years ago.
These patches were made with git format-patch

Change History

follow-up: ↓ 2   Changed 5 years ago by pingou

in reply to: ↑ 1   Changed 5 years ago by bdusauso

Replying to pingou:

Are you referring to this ?  http://linux.softpedia.com/get/Terminals/VTE-11753.shtml Thanks


I think he means the "Tango" palette from gnome-terminal, for example.

  Changed 5 years ago by n3rd3x

  • owner changed from somebody to n3rd3x

follow-ups: ↓ 5 ↓ 6 ↓ 9   Changed 4 years ago by lincoln

Hmm, I'm not sure that this is useful, anyone realy would like to see this feature in guake? Patches are welcome =)

in reply to: ↑ 4   Changed 4 years ago by czert

  • cc czert added

Replying to lincoln:

Hmm, I'm not sure that this is useful, anyone realy would like to see this feature in guake? Patches are welcome =)

Yes, I'd love that. Changing default to Tango colors would be a great first step; the way I see it, however, the goal should be complete support for multiple color palettes through preferences...

in reply to: ↑ 4   Changed 4 years ago by Slotos

Replying to lincoln:

Hmm, I'm not sure that this is useful, anyone realy would like to see this feature in guake? Patches are welcome =)

Tango theme is way more readable. So yes, I'd really like to see it. And I'm reading docs little by little but I'm still far from modifying guake sources.

  Changed 4 years ago by lincoln

  • version changed from 0.4 to 0.3.1
  • milestone 0.4.0 deleted

Humm, ok but I think it will not be done for the next release.

  Changed 4 years ago by pingou

  • milestone set to 0.5.0

in reply to: ↑ 4   Changed 4 years ago by kek

  • cc kristjan.eerik.kaseniit+guake@… added

Replying to lincoln:

Hmm, I'm not sure that this is useful, anyone realy would like to see this feature in guake? Patches are welcome =)

Looked around in the sources of gnome-terminal and worked out that I needed to add this snipped of code to somewhere (after much thought I still couldn't figure out where would be the best place):

palette = [gtk.gdk.Color(0, 0x2e2e, 0x3434, 0x3636),
	gtk.gdk.Color(0, 0xcccc, 0x0000, 0x0000),
	gtk.gdk.Color(0, 0x4e4e, 0x9a9a, 0x0606),
	gtk.gdk.Color(0, 0xc4c4, 0xa0a0, 0x0000),
	gtk.gdk.Color(0, 0x3434, 0x6565, 0xa4a4),
	gtk.gdk.Color(0, 0x7575, 0x5050, 0x7b7b),
	gtk.gdk.Color(0, 0x0606, 0x9820, 0x9a9a),
	gtk.gdk.Color(0, 0xd3d3, 0xd7d7, 0xcfcf),
	gtk.gdk.Color(0, 0x5555, 0x5757, 0x5353),
	gtk.gdk.Color(0, 0xefef, 0x2929, 0x2929),
	gtk.gdk.Color(0, 0x8a8a, 0xe2e2, 0x3434),
	gtk.gdk.Color(0, 0xfcfc, 0xe9e9, 0x4f4f),
	gtk.gdk.Color(0, 0x7272, 0x9f9f, 0xcfcf),
	gtk.gdk.Color(0, 0xadad, 0x7f7f, 0xa8a8),
	gtk.gdk.Color(0, 0x3434, 0xe2e2, 0xe2e2),
	gtk.gdk.Color(0, 0xeeee, 0xeeee, 0xecec)
	]
	""" I tried it in the show() function and
	    used hardcoded bgcolor and fgcolor
	"""
        #for i in self.term_list:
        #    i.set_colors(bgcolor, fgcolor, palette)

So basically, this is just the Tango palette from gnome-terminal. Too new to guake.py & python to make a patch though, sorry.

follow-up: ↓ 11   Changed 4 years ago by zzrough

you can just add the following in GuakeTerminal#configure_terminal?:

palette = [gtk.gdk.Color(0x2e2e, 0x3434, 0x3636, 0),

gtk.gdk.Color(0xcccc, 0x0000, 0x0000, 0), gtk.gdk.Color(0x4e4e, 0x9a9a, 0x0606, 0), gtk.gdk.Color(0xc4c4, 0xa0a0, 0x0000, 0), gtk.gdk.Color(0x3434, 0x6565, 0xa4a4, 0), gtk.gdk.Color(0x7575, 0x5050, 0x7b7b, 0), gtk.gdk.Color(0x0606, 0x9820, 0x9a9a, 0), gtk.gdk.Color(0xd3d3, 0xd7d7, 0xcfcf, 0), gtk.gdk.Color(0x5555, 0x5757, 0x5353, 0), gtk.gdk.Color(0xefef, 0x2929, 0x2929, 0), gtk.gdk.Color(0x8a8a, 0xe2e2, 0x3434, 0), gtk.gdk.Color(0xfcfc, 0xe9e9, 0x4f4f, 0), gtk.gdk.Color(0x7272, 0x9f9f, 0xcfcf, 0), gtk.gdk.Color(0xadad, 0x7f7f, 0xa8a8, 0), gtk.gdk.Color(0x3434, 0xe2e2, 0xe2e2, 0), gtk.gdk.Color(0xeeee, 0xeeee, 0xecec, 0)]

self.set_colors(gtk.gdk.Color(0, 0xaaaa, 0xaaaa, 0xaaaa), # foreground (gray) - which can not be None (python-vte bug)

gtk.gdk.Color(0, 0x0000, 0x0000, 0x0000), # background (black) - ditto palette) # tango palette

works fine here as long as the opacity is a bit smaller since these colors are less bright than the defaults. since the foreground+background colors are overriden later, do not forget to manually set your foreground color to "aaaaaa" in the guake preferences and you'll get a regular tango theme :p

have fun,

--Stef

in reply to: ↑ 10   Changed 4 years ago by zzrough

stupid me, it's better with a code block:

        palette = [gtk.gdk.Color(0x2e2e, 0x3434, 0x3636, 0),
                   gtk.gdk.Color(0xcccc, 0x0000, 0x0000, 0),
                   gtk.gdk.Color(0x4e4e, 0x9a9a, 0x0606, 0),
                   gtk.gdk.Color(0xc4c4, 0xa0a0, 0x0000, 0),
                   gtk.gdk.Color(0x3434, 0x6565, 0xa4a4, 0),
                   gtk.gdk.Color(0x7575, 0x5050, 0x7b7b, 0),
                   gtk.gdk.Color(0x0606, 0x9820, 0x9a9a, 0),
                   gtk.gdk.Color(0xd3d3, 0xd7d7, 0xcfcf, 0),
                   gtk.gdk.Color(0x5555, 0x5757, 0x5353, 0),
                   gtk.gdk.Color(0xefef, 0x2929, 0x2929, 0),
                   gtk.gdk.Color(0x8a8a, 0xe2e2, 0x3434, 0),
                   gtk.gdk.Color(0xfcfc, 0xe9e9, 0x4f4f, 0),
                   gtk.gdk.Color(0x7272, 0x9f9f, 0xcfcf, 0),
                   gtk.gdk.Color(0xadad, 0x7f7f, 0xa8a8, 0),
                   gtk.gdk.Color(0x3434, 0xe2e2, 0xe2e2, 0),
                   gtk.gdk.Color(0xeeee, 0xeeee, 0xecec, 0)]

        self.set_colors(gtk.gdk.Color(0, 0xaaaa, 0xaaaa, 0xaaaa), # foreground (gray)  - which can not be None (python-vte bug)
                        gtk.gdk.Color(0, 0x0000, 0x0000, 0x0000), # background (black) - ditto
                        palette)                                  # tango palette

  Changed 4 years ago by pingou

  • milestone changed from 0.5.0 to 0.6.0

hm let's keep this in mind but I'll postpone it to 0.6.0

Changed 3 years ago by tatofoo

Let you choose a color palette in the preferences dialog

  Changed 3 years ago by tatofoo

I've attached a file that lets you choose the color palette you want to use (included Tango) in the preferences dialog, hope it helps.

 http://imgur.com/oIFyH.png

Changed 3 years ago by tatofoo

These patches were made with git format-patch

Changed 3 years ago by tatofoo

These patches were made with git format-patch

Changed 3 years ago by tatofoo

These patches were made with git format-patch

Changed 3 years ago by tatofoo

These patches were made with git format-patch

  Changed 3 years ago by marcin

Hi,

+1 for this ticket from my side. Choosing a colour palette is the only thing I am currently missing in Guake. And I am pretty sure there is more of us coders who use vim and simply would love to see Guake using other colours than the default ones!

I am really looking forward to getting this ticket done!

Cheers, Marcin

  Changed 3 years ago by lincoln

  • status changed from new to closed
  • resolution set to fixed

there are sooo many people waiting for this... I've finally had some time to look at it!

Thank you very much for your work, I've just pushed your patches to our master branch.

  Changed 12 months ago by lincoln

  • milestone 0.6.0 deleted

Milestone 0.6.0 deleted

Note: See TracTickets for help on using tickets.