"Hide on lose focus" function doesn't work.

[idyllic]

Hi, I built and installed from scratch Guake 0.3. Everything works smoothly. Only "Hide on lose focus" function doesn't work - as I tried Alt-Tab and switch desktop to change focus from Guake. There is no error message from the terminal =/

I'm on Ubuntu Hardy 8.04.1 with all the latest updates.

Thanks for a great program.

[bdusauso]

I confirm this behaviour. I have nearly exactly the same system (Hardy 8.04.1 with latest updates) but I've installed the debian package of Guake.

[GabrielFalcao]

I am going to review this functionallity

[gwrynn]

Could it be that the fix is as simple as this patch? The window should be visible to hide() it...

(sorry for pasting stuff here, but attaching a file in trac failed for me...)

diff --git a/src/guake.py b/src/guake.py
index 5f5f8d9..f48f3bb 100644
--- a/src/guake.py
+++ b/src/guake.py
@@ -704,7 +704,7 @@ class Guake(SimpleGladeApp):
     def on_window_lostfocus(self,window, event):
         getb = lambda x:self.client.get_bool(x)
         value = getb(GCONF_PATH+'general/hide_on_lost_focus')
-        if value and not self.visible:
+        if value and self.visible:
             self.hide()
 
     def check_widgets_visibility(self):
-- 

[lincoln]

Thank you for your contribution, this was fixed some commits ago =)